search

felixfbecker / svg-screenshots

📸🧩 Browser extension to take scalable, semantic, accessible screenshots of websites in SVG format.
809 stars 29 forks source link

TypeError: value is undefined at content.ts:28:8 #79

Open meithecatte opened 3 years ago

meithecatte commented 3 years ago

Steps to reproduce:

  1. Visit https://cloud.binary.ninja
  2. Click "Capture viewport" in the extension's menu.
  3. Observe error: svg-error
felixfbecker commented 3 years ago

I can't reproduce this error. Could you tell me which version, browser and settings you're using?

meithecatte commented 3 years ago

I am using Firefox 88.0.1 and SVG Screenshot 0.11.0. I can see that addons.mozilla.org has 0.11.1 and GitHub has 0.11.2, so this might be due to my using an outdated version. I don't see how to update it, though. I seem to have automatic updates enabled, and even a manual "check for updates" doesn't notice the new version... updates

meithecatte commented 3 years ago

These are the settings I'm using, FWIW. settings

felixfbecker commented 3 years ago

The release pipeline was broken on Firefox because it now requires 2FA, thanks for letting me know!

The Firefox extension should be up to date now. Could you update to 0.11.6 and let me know if you still have this issue?

FWIW I tried it with the previous version and didn't have the error. Maybe we're not seeing the same content on the page, are you signed in? I'm seeing this:

image

Which is producing this SVG for me:

Binary Ninja Cloud Screenshot.svg.zip

Firefox 88.0.1, macOS.

felixfbecker commented 3 years ago

If it's not updating, try uninstalling and reinstalling.