Make pprof the default format, remove guessing

felixge / fgprof

🚀 fgprof is a sampling Go profiler that allows you to analyze On-CPU as well as Off-CPU (e.g. I/O) time together.

MIT License

2.81k stars 88 forks source link

Make pprof the default format, remove guessing #2

Closed felixge closed 4 years ago

felixge commented 4 years ago

@swatson314159 reported that the current behavior is confusing in GH issue #1, and I agree. Hopefully the new behavior is less surprising.

felixge commented 4 years ago

@swatson314159 awesome! Yeah, I love Brenden's work as well, and my first prototype for fgprof only supported his output format. It's far more elegant than Go's complicated protobuf stuff ... but I suspect that many gophers will find the compatibility with the pprof visualizer very compelling and gravitate towards it by default.

So yeah, this is probably the right thing to do. Thanks for reviewing!