Default time to 30s, to align with the pprof/profile default timeout

felixge / fgprof

🚀 fgprof is a sampling Go profiler that allows you to analyze On-CPU as well as Off-CPU (e.g. I/O) time together.

MIT License

2.88k stars 96 forks source link

Default time to 30s, to align with the pprof/profile default timeout #3

Closed howardjohn closed 4 years ago

howardjohn commented 4 years ago

Currently if you call the standard pprof endpoint without ?timeout set, it will default to 30. With fgprof, this just fails. It would be nice to retain this defaulting behavior.

felixge commented 4 years ago

@howardjohn good idea, thx : ).

PTAL at https://github.com/felixge/fgprof/pull/4 and confirm if that's what you had in mind.

felixge commented 4 years ago

Fixed in https://github.com/felixge/fgprof/pull/4