search

felixge / fgprof

🚀 fgprof is a sampling Go profiler that allows you to analyze On-CPU as well as Off-CPU (e.g. I/O) time together.
MIT License
2.81k stars 88 forks source link

Default to 30s duration like net/http/pprof #4

Closed felixge closed 3 years ago

felixge commented 3 years ago

GH-Issue: https://github.com/felixge/fgprof/issues/3

cristaloleg commented 3 years ago

Probably timeout will be better (same as pprof), wdyt?

felixge commented 3 years ago

@cristaloleg afaik Go also calls this argument seconds, not timeout?

See https://golang.org/src/net/http/pprof/pprof.go?s=3563:3615#L109

cristaloleg commented 3 years ago

Yep, you're right! Was looking at #3 with ?timeout in text :(

chonlasit907 commented 3 years ago

https://golang.org/src/net/http/pprof/pprof.go?s=3563:3615#L109

felixge commented 3 years ago

Yep, you're right! Was looking at #3 with ?timeout in text :(

No worries, I got confused by that as well, but I assume @howardjohn meant to write seconds, not timeout.

howardjohn commented 3 years ago

Yep I meant seconds, sorry for the confusion!