felixge / node-cross-compiler

Simplified cross compiling for node.js using vagrant.
105 stars 27 forks source link

Clone only the needed branch to speed things up #2

Closed yocontra closed 11 years ago

yocontra commented 11 years ago

Could possible be replaced with

mkdir node
cd node
git init
git remote add -t ${NODE_BRANCH} -f origin ${NODE_REPO}
git checkout ${NODE_BRANCH}
felixge commented 11 years ago

Would that actually yield much benefits considering that most objects in recent node branch will usually be linked to the entire history?

yocontra commented 11 years ago

@felixge - It took the clone time from a minute to a few seconds in my testing

rmehner commented 11 years ago

Was just going to fix that, but as it is already here:

+1 to that, especially useful on hackathons where the internet connection isn't that good (like some of the connections we had at some NodeCopters)

felixge commented 11 years ago

@Contra / @rmehner you're both contributors now, feel free to push patches as you see fit!

yocontra commented 11 years ago

Sweet thanks! I've got some automated starter scripts that handle the whole process I'll put up

yocontra commented 11 years ago

I fixed this in master AFAIK closing it now

felixge commented 11 years ago

@Contra :heart: thank you so much!

yocontra commented 11 years ago

@felixge - Are you okay with the other changes I made?

felixge commented 11 years ago

@felixge - Are you okay with the other changes I made?

Just had a look! Yes! Awesome stuff. :heart: the ftp deployment thing!