Set default timestamp when both time and callback are omitted

felixge / node-graphite

A node.js client for graphite.

106 stars 16 forks source link

Set default timestamp when both time and callback are omitted #11

Closed HughePaul closed 6 years ago

HughePaul commented 6 years ago

Set default timestamp when both time and callback are omitted
Set travis testing on later node versions
Make package.json run make tests using npm test Fixes #10

Serphentas commented 6 years ago

Looks good. For some reason, unit tests on older versions of Node fail.

HughePaul commented 6 years ago

It looks like travis can no longer install npm for node 0.4 and node 0.6, but it is passing for later versions

Serphentas commented 6 years ago

I should look into proper unit testing when I have time.

For now, I will make a new release using this PR. Thank you for your contribution !

HughePaul commented 6 years ago

Would it make sense to get travis to only test later versions and 0.10 or 0.12 (which i believe travis cans still test)? I could update the first commit of this PR to test: 0.10, 0.12, 4, 8

HughePaul commented 6 years ago

ah missed the merge :) thanks

Serphentas commented 6 years ago

You can open a new issue regarding this matter if you wish, so that we can keep stuff better separated.

As for this PR, here's the GitHub release. I've also published it to npm so you should be able to get it from there.