felixge / node-graphite

A node.js client for graphite.
106 stars 16 forks source link

Fix graphite client reconnections on Node 16 and above #17

Closed jonathansamines closed 2 years ago

jonathansamines commented 2 years ago

Fix graphite client reconnections by bundling lazy-socket into this module. Work was divided into multiple commits:

Fixes https://github.com/felixge/node-graphite/issues/16

Serphentas commented 2 years ago

LGTM. I think we should release this as a new patch version (i.e. 0.1.5) since there are no major changes (API is untouched).

Serphentas commented 2 years ago

There you go https://github.com/felixge/node-graphite/releases/tag/v0.1.5

jonathansamines commented 2 years ago

Hey @Serphentas thanks for reviewing these changes. Have they already been published to npm?

Serphentas commented 2 years ago

I'm having trouble logging into my npm account, I will let you know when it's published ASAP.

Serphentas commented 2 years ago

Here it is https://www.npmjs.com/package/graphite/v/0.1.5 thanks for your contribution !

jonathansamines commented 2 years ago

Awesome, thank you @Serphentas