Closed jonathansamines closed 2 years ago
LGTM. I think we should release this as a new patch version (i.e. 0.1.5) since there are no major changes (API is untouched).
Hey @Serphentas thanks for reviewing these changes. Have they already been published to npm?
I'm having trouble logging into my npm account, I will let you know when it's published ASAP.
Here it is https://www.npmjs.com/package/graphite/v/0.1.5 thanks for your contribution !
Awesome, thank you @Serphentas
Fix graphite client reconnections by bundling
lazy-socket
into this module. Work was divided into multiple commits:lazy-socket
source code and tests into this module. Source code was copied as last published in npm. Tests are failing in Node.js 16 at this point as described by https://github.com/felixge/node-lazy-socket/issues/3lazy-socket
source code to restore the automatic reconnection functionality on terminated connectionsFixes https://github.com/felixge/node-graphite/issues/16