Closed searls closed 10 years ago
:+1:
This looks very good. I only have the one comment, about how making Istanbul a new default might not be great, and also that the defaults should be configurable project-wide (so e.g. people who want to use, say, traceur, should be able to add a traceur source transformer once instead of on every require
).
Also, since I am no longer actively using this module, if @felixge is OK with it, I think it'd be cool to add you as a maintainer on GitHub and npm, continuing the chain of custodion-ship transfer that started when @felixge handed this off to me :).
This looks very good. I only have the one comment, about how making Istanbul a new default might not be great, and also that the defaults should be configurable project-wide (so e.g. people who want to use, say, traceur, should be able to add a traceur source transformer once instead of on every require).
I agree with Dominic, but since I'm not actively maintaining this module right now, I'm not feeling strongly about it ; ).
Also, since I am no longer actively using this module, if @felixge is OK with it, I think it'd be cool to add you as a maintainer on GitHub and npm, continuing the chain of custodion-ship transfer that started when @felixge handed this off to me :).
Done. @searls you now have github / npm push access! Feel free to merge this patch once you're happy with it.
Thanks @felixge & @domenic. I'm going to take a look at implementing two pieces of your feedback before merging this.
Okay, I've made both those changes. Hopefully being able to set an app-wide global or require() stubbing will be of use to people even if the sourceTransformers
& istsanbul stuff doesn't serve them. :smile:
I'll merge and push a version, bumping minor.
Ping @felixge -- it looks like I don't have Github Push access to this repo, after all :)
@searls that's weird, it seems like GitHub forgot that I added you. Did you get an e-mail you were added? Anyway, I just added you again, should work now.
Thanks folks. Released as 0.3.0.
:sparkling_heart: thx!
This PR addresses #25. Three changes in this PR:
_getCompileInfo()
methodsourceTransformers
option passed toSandboxedModule.require
.I was sure to add unit tests to cover everything I did. I tried to write everything I added in a manner that was congruent with the existing code.
Suggestions: