search

felixge / node-sandboxed-module

A sandboxed node.js module loader that lets you inject dependencies into your modules.
MIT License
342 stars 42 forks source link

Add source code instrumentation support for the 'blanket' coverage tool #28

Closed lovell closed 10 years ago

lovell commented 10 years ago

Hello,

I've added support for Alex Seville's blanket code coverage library, very much in the vein of the existing istanbul code coverage support.

There's a fairly simple unit test that verifies the state of the baz test fixture source code both before and after adding instrumentation.

I also removed Node.js versions 0.6 and earlier from the Travis CI job as these are no longer supported - https://github.com/npm/npm/issues/4379 provides more details.

Cheers, Lovell

domenic commented 10 years ago

Can't you just publish a separate source transformer and instruct people to use that?

searls commented 10 years ago

Agreed. The goal of the source transformer meme was to make it possible / easy for others to publish their own interceptors without requiring changes to this module itself. 

Not because your plugin is any less valuable, but to avoid the maintenance risk posed by a bunch of—for existing users—unnecessary additions.

On Wed, Jan 8, 2014 at 11:11 AM, Domenic Denicola notifications@github.com wrote:

Can't you just publish a separate source transformer and instruct people to use that?

Reply to this email directly or view it on GitHub: https://github.com/felixge/node-sandboxed-module/pull/28#issuecomment-31848425

lovell commented 10 years ago

No probs, I'm happy to publish this as its own module. Thanks both for your swift replies.