search

felixge / nodeguide.com

My unofficial and opinionated guide to node.js.
http://nodeguide.com/
370 stars 43 forks source link

Minor typos #12

Closed dideler closed 13 years ago

dideler commented 13 years ago

On the beginner page, in the installation section:

$ wget http://nodejs.org/dist/node-v0.4.4.tar.gz

$ tar -xzf node-v0.4.4.tar.gz

$ cd node-v0.4.4.tar.gz

$ ./configure

$ sudo make install

I think it would be better to use something such as node-v0.x.x.tar.gz so that it's less obvious that the displayed version is outdated. Also, cd node-v0.4.4.tar.gz should be cd node-v0.4.4/ (or cd node-v0.x.x/).

Cheers, Dennis

oschrenk commented 13 years ago

May be point to http://nodejs.org/dist/node-latest.tar.gz ?

( Unfortunately this points to the 0.4 release instead of the latest 0.4.6 release. )

dideler commented 13 years ago

I think that's a good solution. It won't have minor updates, but it will be the latest major version.

oschrenk commented 13 years ago

I opened an issue at joyent/node to discuss whether minor releases should be pointed at.

https://github.com/joyent/node/issues/942

oschrenk commented 13 years ago

So

$ wget http://nodejs.org/dist/node-latest.tar.gz
$ tar -xzf node-latest.tar.gz
$ cd node-latest

doesn't work as of right now because node-latest.tar.gz is unpacked to node-0.4.5.

May be writing node-v0.x.x/ is the better solution. Or the the archive node-latest.tar.gz differently (which is a little much to ask maybe).

dideler commented 13 years ago

I just checked out the status of the issue you opened at joyent/node and Ryan fixed it. So now Felix's guide can safely point to node-latest.tar.gz. Unless of course he wants to purposely point to v0.4.4 because that's the version the guide was written for.

oschrenk commented 13 years ago

No. See my previous comment https://github.com/felixge/nodeguide.com/issues/12#issuecomment-1014898 The tar.gz archive is just the latest release renamed. So if you unpack it you still get a directory named 0.x.x. So you still get a "dependency" to a specific release.

I changed my opinion on this and its fine IMO. If you revisit the guide in the future you still want the examples to work, so fetching a release explicitly is OK. Perhaps there can be a comment on how the latest release can be obtained. Is that what you meant?

dideler commented 13 years ago

A comment on how to obtain the latest release is probably not necessary. My original intention was to avoid confusion for anyone who reads the guide in the future and notices that v0.4.4 is an outdated version. I'm closing the issue, more time is probably being spent discussing it than the minuscule benefits that would be gained.