search

felixguendling / cista

Cista is a simple, high-performance, zero-copy C++ serialization & reflection library.
https://cista.rocks
MIT License
1.78k stars 113 forks source link

update cmake version to avoid error #100

Closed westfly closed 3 years ago

westfly commented 3 years ago

build with cmake3.6 will get error

Make Error at tools/doctest/CMakeLists.txt:5 (target_compile_features):
  target_compile_features specified unknown feature "cxx_std_11" for target
  "cista-doctest".

CMake Error at tools/uniter/CMakeLists.txt:4 (target_compile_features):
  target_compile_features specified unknown feature "cxx_std_17" for target
  "uniter".

CMake Error at CMakeLists.txt:90 (target_compile_features):
  target_compile_features specified unknown feature "cxx_std_17" for target
  "cista-test-single-header".

-- Configuring incomplete, errors occurred!

It looks like cxx_std_17 was added in CMake 3.8: https://cmake.org/cmake/help/v3.8/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html

SO pls change from 3.5 to 3.8

cmake_minimum_required(VERSION 3.8)
felixguendling commented 3 years ago

Thank you. Should be fixed now.