search

felixguendling / cista

Cista is a simple, high-performance, zero-copy C++ serialization & reflection library.
https://cista.rocks
MIT License
1.8k stars 116 forks source link

basic_unique_ptr: reset on move assignment #176

Closed AdelKS closed 1 year ago

AdelKS commented 1 year ago

Hello!

While I was running asan and tsan tests on my project, I met a memory leak. It took me a while, but I found the culprit ! I think cista definitely needs to have its tests run with the address sanitizer.

Now that I think about it: maybe it's worth specialising std::swap for cista's classes.

Adel

felixguendling commented 1 year ago

The CI tests run already with -fsanitizer=address,undefined. The problem in this case is test coverage. I'm open to merge PRs that increase test coverage (or std::swap specializations).