felixguendling / cista

Cista is a simple, high-performance, zero-copy C++ serialization & reflection library.
https://cista.rocks
MIT License
1.74k stars 110 forks source link

Support for `resize` [perhaps also `capacity` and `reserve`] for cista::generic_string/basic_string #189

Open ChemistAion opened 1 year ago

ChemistAion commented 1 year ago

There is a usage pattern for string like types when internal buffer (with known size a priori)] is filled later, e.g.: https://github.com/ocornut/imgui/blob/master/misc/cpp/imgui_stdlib.cpp

Could you please consider to add resize() or even more - additionally with: capacity() and reserve() to mimic what the gang from std does... just to handle such callback-cases in a elegant way :innocent:

ChemistAion commented 1 year ago

For now, for this particular usage I have this thing:

struct InputTextCallback_Meta
{
    madX::Meta::String* string_;
    ImGuiInputTextCallback chain_callback_;
    void* chain_user_data_;
};

static int Meta_InputTextCallback(ImGuiInputTextCallbackData* data)
{
    InputTextCallback_Meta* user_data = (InputTextCallback_Meta*)data->UserData;
    if (data->EventFlag == ImGuiInputTextFlags_CallbackResize)
    {
        madX::Meta::String* string = user_data->string_;
        IM_ASSERT(data->Buf == string->data());

        string->move_from(madX::Meta::String("", data->BufTextLen < madX::Meta::StringShortLength ? madX::Meta::StringShortLength : data->BufTextLen));
        data->Buf = string->data();
    }
    else if (user_data->chain_callback_)
    {
        data->UserData = user_data->chain_user_data_;
        return user_data->chain_callback_(data);
    }
    return 0;
}

bool ImGui::InputTextWithHint(const char* label, const char* hint, madX::Meta::String* string, ImGuiInputTextFlags flags, ImGuiInputTextCallback callback, void* user_data)
{
    IM_ASSERT(string);
    IM_ASSERT((flags & ImGuiInputTextFlags_CallbackResize) == 0);
    flags |= ImGuiInputTextFlags_CallbackResize;

    InputTextCallback_Meta meta
    {
        string,
        callback,
        user_data
    };

    return InputTextWithHint
    (
        label,
        hint,
        string->data(),
        string->size() + 1,
        flags,
        Meta_InputTextCallback,
        &meta
    );
}

Works flawlessly, but it is not elegant, take a look on Meta_InputTextCallback(...) where I have a hack (forced heap storage) instead of nice .resize() - due to: https://github.com/felixguendling/cista/issues/190

btw:

ChemistAion commented 7 months ago

I will check the impact here of what @khng300 did in the: https://github.com/felixguendling/cista/issues/187