_MSC_VER not defined in msys(mingw64) and cista doesn't compile

felixguendling / cista

Cista is a simple, high-performance, zero-copy C++ serialization & reflection library.

https://cista.rocks

MIT License

1.82k stars 118 forks source link

_MSC_VER not defined in msys(mingw64) and cista doesn't compile #89

Closed BinaryCat17 closed 3 years ago

BinaryCat17 commented 3 years ago

On windows with msys(mingw64) very strange behavior occurs. Cista tries include linux headers on windows and file.h uses linux implementation. I replace _MSC_VER with _WIN32 and and changed the compile conditions a little in many places and cista started to work well. I'm not sure that I did well, but it works.

felixguendling commented 3 years ago

Can you please make you pull request with your changes?

BinaryCat17 commented 3 years ago

I apologize for the long delay in reply. I created a pull request. Also, when using mmap with the modify flag, an exception is thrown : "open file mode not supported" in function "open_file".