issue-17 - handle code 3200 cleanly

felixhageloh / weather-widget

A weather widget for Übersicht

64 stars 32 forks source link

issue-17 - handle code 3200 cleanly #24

Closed jmcguire closed 7 years ago

jmcguire commented 8 years ago

resolves issue #17

When a weather code 3200 is found, we shouldn't create an image. The Original style was showing the "Fair Weather" image, and Yahoo was showing an image with a broken URL. Now they both show nothing.
Maybe it should show a "no image available" instead? Or create an empty span tag that users can customize as they wish?

felixhageloh commented 8 years ago

Thanks for looking into this! I only had a quick glance, but at least for the non-yahoo icons it looks like there is a proper mapping (it is supposed to show a 'n/a' icon ). So maybe it is worth checking first why that is not working properly

felixhageloh commented 8 years ago

I just saw that there was another commit since my comment - what's the status of this?

felixhageloh commented 7 years ago

closing for now due to inactivity