felixhageloh / weather-widget

A weather widget for Übersicht
64 stars 32 forks source link

Celsius doesn't work #43

Closed jekylgithub closed 5 years ago

jekylgithub commented 5 years ago

Made many changes including opacity: 0.7 change and font sizes of various components to suit desktop, love it, then, as a UK resident, I changed to celsius from fahrenheit, and the widget simply won't display. No error message from ubersicht, but it just disappears. Changing back to fahrenheit in the script does;t make it reappear either. Deleted and reinstalled widget afresh, then just changed the units before any other mod, same thing, needs delete and reinstall again. Shame as I really much prefer celsius to fahrenheit

felixhageloh commented 5 years ago

which text editor are you using to make the changes? It sounds like a common issue with TextEdit: it automatically changes regular quotes into 'curly quotes' on save. You can turn this off in Preferences (Options section) -> Smart Quotes, or alternatively, use a different text editor.

jekylgithub commented 5 years ago

Aha, v interesting to know, Text Edit indeed. Had no idea, will give that a try. When i reopened things to check and try repeatedly, it did seem to have kept the ‘quotes’ I used instead of changing but will look.

Thanks so much for the reply

J

On 8 Oct 2018, at 11:42, Felix notifications@github.com wrote:

which text editor are you using to make the changes? It sounds like a common issue with TextEdit: it automatically changes regular quotes into 'curly quotes' on save. You can turn this off in Preferences (Options section) -> Smart Quotes, or alternatively, use a different text editor.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/felixhageloh/weather-widget/issues/43#issuecomment-427789265, or mute the thread https://github.com/notifications/unsubscribe-auth/ApxQ7YFDLJHiDNgRU6CSKUmFnXELJf4Bks5uiywhgaJpZM4XFDen.

felixhageloh commented 5 years ago

👍 glad I could help. The change is very subtle:

" vs “

and

' vs ‘