Putting back icons.svg, adding optional requests library

[nickroberts]

Sorry about those icons!

I put back the icons.svg file, along with adding an option to use the python requests library.

Very weird how I was getting an HTTP version not supported error while at the local coffeeshop.

Also updated the README, explaining how to use the requests library.

Thanks!

[felixhageloh]

No worries! So I had a go at it as well; added an option to switch between fahrenheit and celsius and cleaned up a few things. The code has diverged quite a bit - mostly because I switched to nodejs for the weather script (don't really know python and I had to change a few things), so I am not sure what the best way to proceed is. I'll probably issue a pull request to your repo and then we can update this pull request :)

[felixhageloh]

forgot to mention: almost done, but I want to cleanup the stylesheet a bit (for the original style)

[felixhageloh]

Ok I think I found the best workflow: I created a new branch called yahoo, into which i merged your pull request. You can fork off that branch if you want to continue pushing changes. That way I can easily merge your pull reqs and we can continue working on the widget till it is done. The problem with master is that all changes go live immediately.

[felixhageloh]

here is the branch btw: https://github.com/felixhageloh/weather-widget/tree/yahoo

[nickroberts]

Looks good!

I would add a package.json file, so the user just needs to run nom install.

Did you want me to play around with it, or do you have it handled?

Thanks!

~n

On Nov 2, 2014, at 9:51 AM, Felix notifications@github.com wrote:

here is the branch btw: https://github.com/felixhageloh/weather-widget/tree/yahoo https://github.com/felixhageloh/weather-widget/tree/yahoo — Reply to this email directly or view it on GitHub https://github.com/felixhageloh/weather-widget/pull/6#issuecomment-61409539.

[felixhageloh]

I think I have it covered, but feel to push increments whenever you like! Not sure what you mean with the package.json file. At the moment I am only using build in nodejs modules (which is partially why the get-weather script is so much code), so there is no need to run npm install unless I am missing something.

[nickroberts]

From what I can tell, unless you have the http and querystring modules installed globally, the script will not run.

If you create a package.json with those 2 modules required, it will download them and install them when you run nom install in the directory.

I do not have those modules installed, so I needed to do a local nom install http querysting so it would put those modules in the weather.widget directory.

I am not a big time node developer by any means, that’s just the way I have done it.

I’m no python developer, either :) It was just easy to create that script, too :)

Great job, btw!

~n

On Nov 4, 2014, at 1:19 PM, Felix notifications@github.com wrote:

I think I have it covered, but feel to push increments whenever you like! Not sure what you mean with the package.json file. At the moment I am only using build in nodejs modules (which is partially why the get-weather script is so much code), so there is no need to run npm install unless I am missing something.

— Reply to this email directly or view it on GitHub https://github.com/felixhageloh/weather-widget/pull/6#issuecomment-61687970.

[felixhageloh]

So, this has been finally released :) Thanks again for you help, great job! Btw, I double checked about the npm modules, and it really looks like you don't have to install them - they are part of node

[nickroberts]

Awesome!

Maybe my system is wacky. Ha!

Thanks!

~n

Sent from my iPhone

On Nov 9, 2014, at 8:07 AM, Felix notifications@github.com wrote:

So, this has been finally released :) Thanks again for you help, great job! Btw, I double checked about the npm modules, and it really looks like you don't have to install them - they are part of node

— Reply to this email directly or view it on GitHub.

[finfio]

I'm trying to customize your widget for my own location Padov (Padua) in Italy... I'm trying to set region to "PD" or "IT" or Italy etc, but it gives me token ILLEGAL. Should I make any correction to the code? Thank you in advance, Fiorenzo Italy

[martinorob]

City = Padova Region = Italy

;)

Martino

Inviato da iPhone

Il giorno 09/feb/2015, alle ore 13:11, finfio notifications@github.com ha scritto:

I'm trying to customize your widget for my own location Padov (Padua) in Italy... I'm trying to set region to "PD" or "IT" or Italy etc, but it gives me token ILLEGAL. Should I make any correction to the code? Thank you in advance, Fiorenzo Italy

— Reply to this email directly or view it on GitHub.

[finfio]

Sorry. The problem was my text editor substituting '' with " Now it works!

Il lunedì 9 febbraio 2015, martinorob notifications@github.com ha scritto:

City = Padova Region = Italy

;)

Martino

Inviato da iPhone

Il giorno 09/feb/2015, alle ore 13:11, finfio <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> ha scritto:

I'm trying to customize your widget for my own location Padov (Padua) in Italy... I'm trying to set region to "PD" or "IT" or Italy etc, but it gives me token ILLEGAL. Should I make any correction to the code? Thank you in advance, Fiorenzo Italy

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/felixhageloh/weather-widget/pull/6#issuecomment-73500864 .

Fiorenzo Fina Mobile: +39-334-5645440 Email: finfio@gmail.com Address: via Fowst, 10/B - 35135 Padova - Italy http://it.linkedin.com/in/fiorenzofina/

[felixhageloh]

no worries, great you figured it out!