search

felixhagspiel / jsOnlyLightbox

Responsive Lightbox in plain JS. No need for jQuery.
MIT License
157 stars 49 forks source link

add background image support #25

Closed milanffm closed 8 years ago

milanffm commented 8 years ago

it works, but every time when I click on the last or first image I get an 404 javascript error. I didn't figure out why :-( ... but it still works well.

felixhagspiel commented 8 years ago

What is it you actually want to achieve? Where do you want a background image? Or do you want to use the CSS property background-image: url(...);?

milanffm commented 8 years ago

yes I use as an background-image ... like:

<div class="g-items" data-src="fileadmin/user_upload/taipei_009.jpg" style="background-image:url(fileadmin/user_upload/taipei_009.jpg)" data-jslghtbx-group="mygroup1" data-jslghtbx-caption="" data-jslghtbx="fileadmin/user_upload/taipei_009.jpg"></div>

then I use the Lightbox script to create a background image form the data-src. But only in the teaser view not By the open lightbox.

felixhagspiel commented 8 years ago

Please check this https://github.com/felixhagspiel/jsOnlyLightbox/issues/18 , I added support for non-image thumbnails