search

felixhagspiel / jsOnlyLightbox

Responsive Lightbox in plain JS. No need for jQuery.
MIT License
157 stars 51 forks source link

Add CSS class to enable fallback links #6

Closed dandersson closed 9 years ago

dandersson commented 9 years ago

Adding the class jslghtbx-fallback-link to a surrounding link element will now still trigger the Lightbox on click, but also allow a fallback mechanism for non-JavaScript-enabled browsing to still present those users with a link to e.g. the full-size image. It also enables the expected actions for both JS and non-JS browsing when e.g. middle-clicking to open the full-size link in the background and such.

The chosen approach can certainly be discussed, but I wanted the function myself, so I might as well lift the issue upstream with a sample implementation.

Side-note: I see that minified files were recently added to the repository. That makes it easier for people to just clone and directly use minified files, but it also makes pull requests a bit "incomplete" without regenerating those, which opens up a couple of issues (tools used, settings, test suites, etc.). This pull request does not include a regenerated minified file.

felixhagspiel commented 9 years ago

hey @dandersson , thanks for contributing! Could you please change that pullrequest to merge with the development-branch? Also, getElementsByClassName is not supported in IE8, but I will fix that. And you are right about the minified CSS/JS, but I think that there are some people who dont know how to minify files, thats why I included them. But maybe I take them out and put a link to an online minifier somewhere.

dandersson commented 9 years ago

@felixhagspiel: Sure, sorry, did not notice that branch in my frenzy :-) . I opened #10 with a pull request to the development branch. Closing here.