felixhayashi / TW5-TiddlyMap

Map drawing and topic visualization for your wiki
http://tiddlymap.org
BSD 2-Clause "Simplified" License
845 stars 127 forks source link

Error message on local media annotation using mediaplayer plug in when the focus tiddler is active in sidebar #443

Closed arunnbabu81 closed 1 year ago

arunnbabu81 commented 1 year ago

https://github.com/buggyj/mediaplayer/issues/9#issue-1567997000

Can you take a look at this issue.

I got an error message like shown below when I clicked on the button to start annotating a local video file using mediaplayer plug in by buggyj. This occurs only if there is focus tiddler active in the sidebar. Focus tiddler is taken from this discussion image

buggyj suggested that this issue may be related to Tiddlymap.

flibbles commented 1 year ago

I don't suppose you could install the non-uglified version of tiddlymap for that stack trace, could you?

arunnbabu81 commented 1 year ago

I don't suppose you could install the non-uglified version of tiddlymap for that stack trace, could you?

I didn't understand fully. How to use uglified version of Tiddlymap? What do you mean by stack trace?

buggyj commented 1 year ago

where is the non-uglified version of the plugin?

flibbles commented 1 year ago

You'd build it. Don't worry about it. I tracked down the bug already. I'll figure out a fix once I'm done with work.

flibbles commented 1 year ago

Fixed in latest release.

arunnbabu81 commented 1 year ago

Fixed in latest release.

Thanks for the fix. its working as expected.

arunnbabu81 commented 1 year ago

I have to report another error with vis library which occurs only if the youtube parser shared in this post is installed in the wiki.

image

Here is the demo

flibbles commented 1 year ago

This is a separate issue.

flibbles commented 1 year ago

Also, this doesn't seem to have anything to do with TiddlyMap. That error points into that youtube plugin.

flibbles commented 1 year ago

The $:/bj/parsers/utubeparser.js is assuming that _canonical_uri is present, but that's not always true. It's a bug in whatever plugin hosts that file. It needs to test for undefined. Not a TiddlyMap issue.

arunnbabu81 commented 1 year ago

I wasn't sure which plug in is the cause of this error....thats why I posted in both GitHub repos. I will wait for buggyj to respond. Thank for the comments @flibbles