search

felixhayashi / TW5-TiddlyMap

Map drawing and topic visualization for your wiki
http://tiddlymap.org
BSD 2-Clause "Simplified" License
863 stars 132 forks source link

Warning: Global assignment detected [ '__core-js_shared__' ] #454

Closed linonetwo closed 9 months ago

linonetwo commented 9 months ago

https://github.com/tiddly-gittly/TidGi-Desktop/issues/385 https://github.com/tiddly-gittly/TidGi-Desktop/issues/460

Warning: Global assignment detected [ '__core-js_shared__' ]

I think this is related your build process (that add the core-js)

Maybe you can try https://github.com/tiddly-gittly/Modern.TiddlyDev for the build, which works very well for tons of our plugins.

flibbles commented 9 months ago

This is likely caused by vis-network. Unfortunately it relies on global assignment to perform a certain task. Unfortunately it's a 3rd party library that doesn't see much love these days, so I doubt I could convince them to change it. Unfortunately TiddlyWiki made a change recently so that Global assignment warnings get printed out like this. At least it's better than what they originally made, which was to make TiddlyWiki crash if global assignment is detected. I had to fight for that.

I don't know if there's anything else I can do for this except that the warning will continue to exist in the browser console for the foreseeable future.

linonetwo commented 9 months ago

Yes, it is not crashing anymore, better than last versions. I think it is accept able now, these warnings won't be seen by the user, only show in the log.