felixjones / github-mgba-rom-test

GitHub Action for unit-testing Game Boy and Game Boy Advance ROMs via mGBA's rom-test frontend
8 stars 1 forks source link

Stop using deprecated `set-output` command. #4

Closed Anders429 closed 6 months ago

Anders429 commented 6 months ago

While using this action, I've noticed a warning:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This PR applies the suggested fix. Prevents the action from being broken whenever they finally decide to fully deprecate set-output.

I verified that this change both gets rid of the warning and still allows the action to work correctly by running with the change here: https://github.com/Anders429/mgba_tests/actions/runs/8547610387

Anders429 commented 6 months ago

This page has examples of the old and the new way: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

(Sorry for closing and reopening, I'm on mobile and I hit the wrong button lol)