search

felixjones / github-mgba-rom-test

GitHub Action for unit-testing Game Boy and Game Boy Advance ROMs via mGBA's rom-test frontend
8 stars 1 forks source link

Updating the binary #5

Open Anders429 opened 3 months ago

Anders429 commented 3 months ago

https://github.com/mgba-emu/mgba/commit/59f4fb71326205d890b75ade9e523fe7b59d2b2f fixed an issue with mgba-rom-test being unable to read config files. This fix means that users will be able to specify their own config through the XDG_CONFIG_HOME env variable, so things like RTC or save type can be specified.

Is there some process for updating the binary? I figured you probably didn't want to just blindly accept a PR with a new binary in it. It doesn't seem like mgba publishes mgba-rom-test executables as part of its regular release package, so I assume you just build them manually?

felixjones commented 3 months ago

Ideally the binary would be built automatically somewhere, but at the moment yes unfortunately it is manually updated

Anders429 commented 3 months ago

I see, that's what I figured. Would you be willing to do a manual update to the binary with the recent bug fix I mentioned included?