search

felixkiss / uniquewith-validator

Custom Laravel Validator for combined unique indexes
MIT License
389 stars 129 forks source link

Add support to Laravel 9 #129

Open gallib opened 2 years ago

gallib commented 2 years ago

Hi,

this PR just add support to upcoming Laravel 9.0

felixkiss commented 2 years ago

Sorry, I missed this completely!

Will verify soon ™️ 🙃

robbielove commented 2 years ago

closes #131

robbielove commented 2 years ago

@felixkiss I would really like this to be merged due to reasons explained in this PR for a different package where I had the same problem: https://github.com/laravelista/comments/pull/183#issuecomment-1056900967

I have looked through the codebase vs the upgrade guide vs this PR The changes would appear to work, but I haven't specifically tested this functionality (I have checked that I can update by composer), or even know how to. I am just a downstream user of this package through rinvex/laravel-support.

I am being held up by the reasons mentioned previously - but in short, If you merge this to master or another branch then that branch can be used without having to add a custom repo fork (laravel shift fork, etc) to each of my apps (just because they use a package which in turn uses this package).

Looking at your branch structure - there's only a single master branch - I would say your branching strategy appears different to that used in laravelista/comments (you probably don't use master as an experimental or unstable branch) - therefore I would suggest you simply change the base of the shift gallib PR to be a new branch called l9-compatibility and merge the shift gallib PR into that - then we can use and test the l9 changes without affecting master branch stability which I suspect you want to preserve, and anyone who wants to use/test the l9 can use it without specifying the laravel shift custom repo. When it's tested enough we can simply PR or merge directly to master - eg. the best of both worlds or win/win.

This is the last remaining dependency for all of my laravel apps to be upgraded - I would appreciate it if you could consider my requests. Any help is appreciated and I thank you for your contribution to this package which in turn helps packages that my package uses. ❤️

edit: my mistake; the laravelista PR was a shift PR, thanks @gallib for this PR

singleseeker commented 2 years ago

Any update？

mattvb91 commented 2 years ago

@felixkiss any chance of getting this in?

mikkoaf commented 2 years ago

Any update on this PR?

EM-LilianaIturribarria commented 1 year ago

Hi, any update on this? we need support for laravel 9 and php > 8.1