search

felixklauke / paper-docker

PaperSpigot Docker. Easy to use and clean docker image for running paper spigot servers in docker containers using OpenJDK. WIP
https://www.felix-klauke.com
MIT License
55 stars 29 forks source link

Add EULA Consent #33

Closed felixklauke closed 2 years ago

felixklauke commented 5 years ago

The user should express their consent via an environment flag at runtime. Consent should NOT be hard coded.

Fjiordor commented 3 years ago

Bumping this. I have not been able to consent to the eula and it is unclear to me where to place the eula.txt (with the agreement) in the mounted volumes.

fisherthewol commented 3 years ago

Currently in the dockerfile, there is the line: ENV JAVA_ARGS="-server -Dcom.mojang.eula.agree=true"

As far as I understand it, making that line ENV JAVA_ARGS="-server -Dcom.mojang.eula.agree=false" would default to not hardcoding consent, and a user could consent using --env JAVA_ARGS="-server -Dcom.mojang.eula.agree=true" at runtime. However that might not be the best answer.