felixklauke / paper-docker

PaperSpigot Docker. Easy to use and clean docker image for running paper spigot servers in docker containers using OpenJDK. WIP
https://www.felix-klauke.com
MIT License
55 stars 29 forks source link

Use 2.7-compatible get-pip.py #66

Closed fisherthewol closed 3 years ago

fisherthewol commented 3 years ago

When updating my server, it errored out at line 74 (build step 28), as the original url now downloads a 3.6+ version of get-pip.py This fix should be treated as temporary, as "pip 21.0 will drop support for Python 2.7 in January 2021." is warned by the script itself. The correct fix may rely on the openjdk images switching to python3, or manually installing python3 in this script.

mbravorus commented 3 years ago

could fix issue #67

fisherthewol commented 3 years ago

Just poking this as it's come into my brain again - if I find the time I'll take a look into whether mcstatus can use python3, and therefore the container could use it if it's not too heavy.

fisherthewol commented 3 years ago

Just poking this as it's come into my brain again - if I find the time I'll take a look into whether mcstatus can use python3, and therefore the container could use it if it's not too heavy.

Ah - looks like https://github.com/ADeeeee/paperspigot-docker/commit/1285d4f50d3f6601d56eaa36ce58dba0384a1130 has already taken a look. Probably just needs assessing whether this adds too much size to the image.