search

felixklauke / paper-docker

PaperSpigot Docker. Easy to use and clean docker image for running paper spigot servers in docker containers using OpenJDK. WIP
https://www.felix-klauke.com
MIT License
55 stars 29 forks source link

Update to 1.18; Move to Paper's V2 API. #74

Closed fisherthewol closed 2 years ago

fisherthewol commented 2 years ago

Attempting to download from the v1 api errors out as it's now deprecated. This PR introduces a new build arg, PAPER_BUILD, to specify the build of paper to download; and moves to the new v2 api. There does not seem to be a latest build option. As well, PAPER_VERSION now has to be the full verison number (EG 1.17.1 instead of just 1.17). A script could be built to discover the latest version, but I'm not well-versed enough to do so.

fisherthewol commented 2 years ago

Would like to point out that the v2 update is from commit 0b2d549 onwards, and I apologise again for the long commit history.

fisherthewol commented 2 years ago

This now also deals with the fact paperclip isn't a thing as of 1.18.

fisherthewol commented 2 years ago

Ok, the Alpine base image doesn't work anymore: https://github.com/PaperMC/Paper/issues/7062 I'll take a look at it again soon.

fisherthewol commented 2 years ago

Just a reminder to self: Tried to use the Eclipse Temurin jdk since they have a still-updated alpine image. I think I've messed something up with the instruction order on my local copy, as I now get a missing file error for the entrypoint script. Will look at it again soon enough.

fisherthewol commented 2 years ago

Ok, apologies, we had a bit of a.... fracas, we'll say. There'll be a new PR for it relatively soon. Apologies.