felixmaker / thunk

Build Rust program to support Windows XP, Vista and more
MIT License
26 stars 4 forks source link

Considering to download and unzip when VC-LTL and YY-Thunks not found #10

Closed felixmaker closed 4 months ago

felixmaker commented 4 months ago

Currently, in order to use thunk-rs, one needs to download VC-LTL and YY-Thunks and add them to system environment. This can be improved by integrating downloading process from GitHub.

There are two basic thoughts:

I decide to achieve it the second way. As the rust programming language now officially support Windows 10 above in Tier 1, I suppose the users are using Windows 10 above. So, the downloading process will be achieved by calling curl command, and the compressed binary will be uncompressed by calling tar command. I will check if these two work later.

The next version will be 0.x.y: x is to fix thunk-rs, and y is to catch up on VC-LTL and YY-Thunks.

felixmaker commented 4 months ago

Currently, I find if support downloading, thunk-rs should be achieved as a dependency not a build dependency. Because in a dependency the program will have to download every time, which is not acceptable. What's more, the tar command does not support lzma, so 7z command line tool needs to be set in path.

felixmaker commented 4 months ago

thunk-rs v0.3.0 as build dependencies should work now.