search

felixmariotto / three-mesh-ui

⏹ Make VR user interfaces for Three.js
https://felixmariotto.github.io/three-mesh-ui/#basic_setup
MIT License
1.26k stars 134 forks source link

Use mergeGeometries instead of mergeBufferGeometries #270

Open mtsmfm opened 10 months ago

mtsmfm commented 10 months ago

Thank you for maintaining awesome library.

Since r151 mergeGeometries is preferrable.

https://github.com/mrdoob/three.js/pull/25652

I checked past PR which addressed similar deprecation warn https://github.com/felixmariotto/three-mesh-ui/pull/230 I believe this library encourages users to update three.js version so I've updated package.json instead of keeping backward compatibility like the following:

import BufferGeometryUtils from 'three/examples/jsm/utils/BufferGeometryUtils.js';

const mergeGeometries =
    BufferGeometryUtils.mergeGeometries ||
    BufferGeometryUtils.mergeBufferGeometries;

Please let me know if you have a concern.