felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.26k stars 359 forks source link

feat: show message under run time if delay has changed #688

Closed emko closed 6 months ago

emko commented 7 months ago

looking a the issue i see you guys don't want to support getting the real run at time from the redis sorted sets score value instead you want bullmq to add job.runAt field, can we at least have this ?

added *Delay changed; the new run time is currently unknown under run at if the initial delay does not equal the current delay as Bullmq does not return a timestamp for when the job will actually run, also i changed it to use the initial delay using the current delay will give you wrong run at time anyways.

image

felixmosh commented 7 months ago

Hi @emko thank you for the PR. Can you elaborate on the issue this PR tries to solve? (example is prefered :] )

emko commented 7 months ago

Hi @emko thank you for the PR. Can you elaborate on the issue this PR tries to solve? (example is prefered :] )

https://github.com/taskforcesh/bullmq/issues/1728

Problem is if you ever change the delay on your job with changeDelay BullMq does not store the new timestamp on the Job, so there is no way on the UI to know when this job will run. This PR just indicates that the jobs delay has been changed, we have many users who complain that jobs are not running when they said they will and this would tell them why it won't

we just have to wait for bullMQ to add something like this https://github.com/taskforcesh/bullmq/pull/1732

but for now i think there should be a warning if the delay has been changed

felixmosh commented 7 months ago

Thank you for the explanation, I'll review that asap

felixmosh commented 6 months ago

Thank you, released in v5.15.0