search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.26k stars 359 forks source link

compactMode: add collapsible functionality + reog job card layout #697

Closed ivnnv closed 6 months ago

ivnnv commented 7 months ago

Yeah this definitelly had a regression bug when I introduced getting the collapseJob settingsStore, this also corrects the double button, having the Collapsible.Trigger is not really needed if we control the state in our Button.

ivnnv commented 7 months ago

hey @felixmosh, modified this and should be ready to merge now

felixmosh commented 7 months ago

Cool, I'll review it asap

felixmosh commented 7 months ago

I've reviewed the PR, it looks buggy... Toggle on the settings should reflect on the screen, but it doesn't, refresh updates to the expected state.

"Collapse job" should define if the card can be collapseable or not (I prefere the full card view), this means that it should add / remove the arrow button.

ivnnv commented 7 months ago

I've reviewed the PR, it looks buggy... Toggle on the settings should reflect on the screen, but it doesn't, refresh updates to the expected state.

This is not needed and it adds unneccesary complexity to the state, a user will normally just define this for the whole session/forever, wont toggle this all the time, but yeah I could make make it work as desired.

"Collapse job" should define if the card can be collapseable or not (I prefere the full card view), this means that it should add / remove the arrow button.

In this case a user would be in need of clicking like crazy for collapsing cards all the time to have a better view of the jobs that are being consumed by the second (if jobs are being properly named you most probably can infer the data they have inside an only would need to expand for specific ones which errors or logs). This would be completely unusable tbh. If this one is a no-no for you, then is a no-no for me too and ill just continue on my fork.

felixmosh commented 7 months ago

@ivnnv think about it, I want the current view (without the clutter of collase expand at all... maybe only the change of the extraction of the id location to the head).

When I enable the collapse job I expect it to collapse all jobs (which is what happining if you refresh the page).

ivnnv commented 7 months ago

@ivnnv think about it, I want the current view (without the clutter of collase expand at all... maybe only the change of the extraction of the id location to the head).

When I enable the collapse job I expect it to collapse all jobs (which is what happining if you refresh the page).

No yeah, I get this point, its def doable and expected if all of the other settings work real-time 👍🏽

ivnnv commented 6 months ago

@felixmosh this should be ready as per your requested changes now

felixmosh commented 6 months ago

Thank you, released in v5.15.0