search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.14k stars 342 forks source link

Revert #592 #703

Closed dimbslmh closed 3 months ago

dimbslmh commented 3 months ago

Maybe something changed recently, but PR https://github.com/felixmosh/bull-board/pull/592 is actually causing issue https://github.com/felixmosh/bull-board/issues/607.

Reverting that change will make PR https://github.com/felixmosh/bull-board/pull/639 unnecessary.

The problem mentioned in PR https://github.com/felixmosh/bull-board/pull/591 doesn't happen anymore.

felixmosh commented 3 months ago

Hi, thank you for this PR. Since I'm not familiar with Nest.js at all, how can I verify that this PR solves mentioned issues?

dimbslmh commented 3 months ago

Hi, thank you for this PR. Since I'm not familiar with Nest.js at all, how can I verify that this PR solves mentioned issues?

I'll try and setup a condesandbox for you later today.

dimbslmh commented 3 months ago

@felixmosh actually.. this PR isn't the solution.

Apparently #592 only applies to Express and #639 adds Fastify support. But both lack a leading forward slash on the prefix to load the static folder correctly. It was mentioned here https://github.com/felixmosh/bull-board/pull/592#issuecomment-1628526095 and again in #607.

Should I update this PR or create a new one?

dimbslmh commented 3 months ago

Closed in favor of #704