search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.14k stars 343 forks source link

Feature: Group Queues by Category #739

Closed manfe closed 4 weeks ago

manfe commented 1 month ago

This PR introduces:

How it works:

https://github.com/felixmosh/bull-board/assets/971608/f4c8f998-86bc-457e-8d30-d546009209ab

felixmosh commented 1 month ago

Hi @manfe thank you for the PR. It is a great feature, but I would like you to make small changes.

  1. Queue search should remain on the left menu (as it was) (your position dosn't make any sense)
  2. Full backward compatability, to keep the current view (if there is only one category, show the corrent view, without collapse & group)
  3. In order to make the code review easier for me, split this PR into several small PRs 🙏🏽,
  4. Don't change example.ts, but add a new example in the examples folder.
manfe commented 1 month ago

@felixmosh regarding your points.

  1. With this PR the search turned global on app and I also want address some responsiveness. The search at top bar from UX works better, because the search is reflecting in the overview page. And for responsiveness the sidebar can be hidden without losing of search feature. Also thinking a little ahead, having search at top bar, probably sidebar will turn useless and the UI can be simplified.

  2. Originally I did that, but I thought that just a default word wouldn't be a problem, and also it was going to motive people using categories to organize their queues. PS: when there is only one category it always start as expanded), but if you really think it's a big deal, I can address it.

  3. Ok, I am going to do these steps:

  1. I am going to create it, with Category Property PR
manfe commented 1 month ago

How I am imagining the UX improvement:

image

manfe commented 1 month ago

After having https://github.com/felixmosh/bull-board/pull/740 and https://github.com/felixmosh/bull-board/pull/741

We can discuss the best implementation for UI/UX part.

That's work for you @felixmosh ?

felixmosh commented 1 month ago

Hi thanks, I'm AFK till Wednesday. Will review ASAP