search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.26k stars 359 forks source link

Feature: Category property #740

Closed manfe closed 3 months ago

manfe commented 4 months ago

This adds the base property category that will be used to display queues organized by categories.

This is a split from the original PR: https://github.com/felixmosh/bull-board/pull/739

felixmosh commented 4 months ago

HI @manfe, can you add the UI usage of the category field in here?

manfe commented 4 months ago

@felixmosh you mean the code for the UI or an image example?

felixmosh commented 4 months ago

The code that actually makes the grouping by category in the UI (menu side bar)

manfe commented 4 months ago

@felixmosh can you review/merge #741 first, because the category feature (collapse/expand) depends heavily on that.

  1. When searching, all categories should expand;
  2. When clear search, collapse all categories.

Also, that PR makes the search results reflect to the overview page which is really good.

felixmosh commented 4 months ago

Grouping is not related to search, let's first merge grouping please.

manfe commented 4 months ago

Grouping is not related to search, let's first merge grouping, please.

It is related. Otherwise, I will need to centralize all the search into the Menu.tsx component and that will add unnecessary complexity to it.

The #741 splits the complexity and also makes it reflect on the overview page.

This entire context, depends on Search Provider.

But if you think that's a big issue, don't worry. I will keep the version that I am using in production already.

felixmosh commented 4 months ago

I don't get it. Can you add the menu grouping by category? why is it related to the global search?