Closed Diluka closed 6 months ago
I would like to make several changes.
attemps
& delay
) via options json propertyI would like to make several changes.
- move the add button to queues actions (3 dots)
- change json editor to somthing that will allow as to specify a schema (current json editor has redandant features)
- make all bull / bullmq add job options available (not only
attemps
&delay
) via options json property
Sorry, I wasn't clear, I will make these changes. Can you revert your latest 2 pushes? (I've made some changes based on your PR.) I will merge it, and apply my changes over it šš½
Sorry, I wasn't clear, I will make these changes. Can you revert your latest 2 pushes? (I've made some changes based on your PR.) I will merge it, and apply my changes over it šš½
I rebased the last commit(add to header) to current(add to ...).
You can continue to rebase, even if all my commits are removed, it doesn't matter.
Can you push them (so I will merge this PR?)
some progress :]
I rebased, so the old commit is lost. there is only new one in the branch.
If it's messed up, you can create a new branch and copy some of my codes. And close this one. it's OK.
OK, I'll check what can be done
Before my trial period ends, Iād better keep a screenshot of it. https://taskforce.sh
This is so weird, what if you want to add other job option, you can't?
I prefer it to allow you to add a json
, with a schema validation.
Maybe to prevent the queue from being broken? These two options are safe. If options are changed incorrectly(failParentOnFailure
, lifo
...), the worker may throw an exception.
The above is my guess. In fact, when I debug the queue myself, I almost never pass the job options.
Can you push them (so I will merge this PR?)
some progress :]
I'm curious how you know what type of job data should be? I remember that there is no type information saved on the queue.
Job data is from type any... so it won't validate it. But job options, can be validated.
Progress :] Schemas are auto generated
Closes #266 Closes #425
Thank you so much for pushing this PR, it helped me to push this required feature to the lib šš½
Released in v5.18.0
š
This is an awesome feature. I wanted to say thank you again for your great work @Diluka @felixmosh
426