felixmosh / bull-board

šŸŽÆ Queue background jobs inspector
MIT License
2.36k stars 366 forks source link

Add Job Modal #744

Closed Diluka closed 6 months ago

Diluka commented 6 months ago

426

felixmosh commented 6 months ago

I would like to make several changes.

  1. move the add button to queues actions (3 dots)
  2. change json editor to somthing that will allow as to specify a schema (current json editor has redandant features)
  3. make all bull / bullmq add job options available (not only attemps & delay) via options json property
Diluka commented 6 months ago

I would like to make several changes.

  1. move the add button to queues actions (3 dots)
  2. change json editor to somthing that will allow as to specify a schema (current json editor has redandant features)
  3. make all bull / bullmq add job options available (not only attemps & delay) via options json property
  1. good point
  2. any suggestions about the json editor? but there is no specific schema, because the data can be any form of json, even primitive values.
  3. I suggest just keep the two options for now. because the official dashboard only has the two options. Leave more advanced features to other people's PRs.
  4. could you please provide an icon for this button?
felixmosh commented 6 months ago

Sorry, I wasn't clear, I will make these changes. Can you revert your latest 2 pushes? (I've made some changes based on your PR.) I will merge it, and apply my changes over it šŸ™šŸ½

Diluka commented 6 months ago

Sorry, I wasn't clear, I will make these changes. Can you revert your latest 2 pushes? (I've made some changes based on your PR.) I will merge it, and apply my changes over it šŸ™šŸ½

I rebased the last commit(add to header) to current(add to ...).

You can continue to rebase, even if all my commits are removed, it doesn't matter.

felixmosh commented 6 months ago

Can you push them (so I will merge this PR?)

some progress :] image

Diluka commented 6 months ago

I rebased, so the old commit is lost. there is only new one in the branch.

If it's messed up, you can create a new branch and copy some of my codes. And close this one. it's OK.

felixmosh commented 6 months ago

OK, I'll check what can be done

Diluka commented 6 months ago
image

Before my trial period ends, Iā€™d better keep a screenshot of it. https://taskforce.sh

felixmosh commented 6 months ago

This is so weird, what if you want to add other job option, you can't? I prefer it to allow you to add a json, with a schema validation.

Diluka commented 6 months ago

Maybe to prevent the queue from being broken? These two options are safe. If options are changed incorrectly(failParentOnFailure, lifo ...), the worker may throw an exception.

The above is my guess. In fact, when I debug the queue myself, I almost never pass the job options.

Diluka commented 6 months ago

Can you push them (so I will merge this PR?)

some progress :] image

I'm curious how you know what type of job data should be? I remember that there is no type information saved on the queue.

felixmosh commented 6 months ago

Job data is from type any... so it won't validate it. But job options, can be validated.

felixmosh commented 6 months ago

Progress :] image Schemas are auto generated

felixmosh commented 6 months ago

Closes #266 Closes #425

felixmosh commented 6 months ago

Thank you so much for pushing this PR, it helped me to push this required feature to the lib šŸ™šŸ½ Released in v5.18.0 šŸŽŠ

snird commented 6 months ago

This is an awesome feature. I wanted to say thank you again for your great work @Diluka @felixmosh