feat: custom job timeline date format

[HitomaruKonpaku]

743

• New config dateFormats in UIConfig
  • short : When timestamp is in same day (today)
  • common : When timestamp is in same year
  • full

Seem like Timeline is the only place that have date/time format, I didn't check other page/component

[felixmosh]

In my opinion this field should be inside locale field, WDYT?

[HitomaruKonpaku]

In my opinion this field should be inside locale field, WDYT?

Hmm I'm not really sure about that.

Will follow your call, but imo it isn't really related to locale since it will now follow the provided format without locale info

[felixmosh]

It is a locale matter, like language (the lng property), no?

[HitomaruKonpaku]

I think it is more of a standard (like ISO 8601) 🤔

Anyway, do you wish to move it into locale ? 😄

[felixmosh]

I'm consulting with you 😄

You convinced me, I will review it soon. Thank you for the PR

[felixmosh]

I've reviewed the PR. I don't like the fact that you are using dateFns.format. can we make some map from strings to Intl config? Maybe expose the entire Intl options

[HitomaruKonpaku]

The thing with Intl.DateTimeFormat is that you can not specify exact format (or maybe I don't know how, please help me on this)

Like with this options (Intl.DateTimeFormat(locale, options)), based on locale config of the app (en-US)

• The result will be 05/18/2024, 04:47:24
• If I try to have locale = ja, it will be 2024/05/18 04:47:24
• But the format I expected is 2024-05-18 04:47:24

    {
      year: 'numeric',
      month: '2-digit',
      day: '2-digit',
      hour: '2-digit',
      minute: '2-digit',
      second: '2-digit',
      hour12: false,
    }

[felixmosh]

Hi, maybe the undefined option here will help you?

console.log(event.toLocaleDateString(undefined, options));
// expected output (varies according to local timezone and default locale): Thursday, December 20, 2012

taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString

[HitomaruKonpaku]

Hi there @felixmosh

This is the result I got

[felixmosh]

Ok, I see that it doesn't solves your issue. I will approve it, and will refactor the it a bit, thank you 🙏

[felixmosh]

Released in v5.18.2