fix(ui): correctly calculate the circumference and offset of the progress citcle

felixmosh / bull-board

🎯 Queue background jobs inspector

MIT License

2.14k stars 343 forks source link

fix(ui): correctly calculate the circumference and offset of the progress citcle #772

Closed henryStelle closed 2 weeks ago

henryStelle commented 3 weeks ago

Closes #771

The stroke-dasharray and stroke-dashoffset were improperly calculated, resulting in the progress circle "completing" when the percentage was only 90%.

Current version:

I refactored the styling to make it more declarative. I also removed the rounded edge on the border so there is a gap with the percentage > 98%.

Fixed version:

felixmosh commented 2 weeks ago

Hi, thank you for this PR 🙏🏼 Can you make sure it works properly in Safari & Firefox?

henryStelle commented 2 weeks ago

Good call, firefox didn't work, but now it does!

felixmosh commented 2 weeks ago

Released in v5.20.2 Thank you