search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.36k stars 366 forks source link

Update Fastify dependencies to support Fastify v5 #824

Closed mduchev closed 2 months ago

mduchev commented 2 months ago

Last week Fastify v5 was released - https://github.com/fastify/fastify/releases

This PR addresses this issue https://github.com/felixmosh/bull-board/issues/823 and updates the relevant dependencies in order to support Fastify v5.

@fastify/static got support for v5 in version 8.0.1 and @fastify/view got support for it in version 10.0.1

felixmosh commented 2 months ago

There are any other breaking changes?

mduchev commented 2 months ago

@felixmosh I'm not sure how to properly test it after the package updates, but taking a look at the release notes for all 3 dependencies, I don't see anything breaking at all. Here's the list of changes:

https://github.com/fastify/fastify-static/releases https://github.com/fastify/point-of-view/releases https://github.com/fastify/fastify/releases

arthurfiorette commented 2 months ago

@felixmosh its safe to merge, both of the dependent packages didn't received any breaking change for support for fastify v5.

arthurfiorette commented 2 months ago

Fastify v5 requires node 20+, this CI configuration is using node 18.

arthurfiorette commented 2 months ago

Node 20 will enter maintaince mode in 2024-10-22, so its safe to repeat this commit, but for 20.x, 22.x.

For those coming here and can't wait for the update, using pnpm/yarn resolutions you can solve this:

"resolutions": {
  "@fastify/static": "^8.0.1",
  "@fastify/view": "^10.0.1"
},
andresribeiro commented 2 months ago 
"@fastify/static": "^8.0.1",
  "@fastify/view": "^10.0.1"

for those using bun as package manager:

"overrides": {
    "@fastify/static": "^8.0.1",
    "@fastify/view": "^10.0.1"
},
felixmosh commented 2 months ago

Thank you for your contribution 🙏🏽

felixmosh commented 2 months ago

Released in V6.0.0