search

felixmosh / bull-board

🎯 Queue background jobs inspector
MIT License
2.36k stars 366 forks source link

Dark mode 🌙 #835

Closed difagume closed 1 month ago

difagume commented 1 month ago

471

Dark mode is added using next-themes, a switch is added in the configuration to be able to change between light and dark, the default mode is the system mode.

1 2 3 4

felixmosh commented 1 month ago

Wow, man, this looks great! Thank you for this PR. I'm not sure why do we need next-theme? With your permission, I would like to change some colors, is that OK by U?

difagume commented 1 month ago

Hi @felixmosh, now that you mention it, you're right about whether next-themes is necessary 🤔. I started by installing next-themes and creating color variables for each style module until I stopped seeing colors that clashed with dark mode. Perhaps without realizing it, I changed all the colors and next-themes might no longer be necessary.

Please feel free to make any adjustments. If you think it can help to have dark mode, I'm very happy to have been able to contribute something. 😊

felixmosh commented 1 month ago

It got released in v6.2.0 There is more room for improvments, but it is Good enough, thanks. I will modify some things with a time...

felixmosh commented 1 month ago

Progress image image image

:]

difagume commented 1 month ago

I was reviewing it, and with the latest adjustments, it looks very good and sharper 👏

felixmosh commented 1 month ago

Fixed all dark mode issues in latest version. Thank you for pushing it :)