felixmosh / knex-paginate

An extension of Knex's query builder with `paginate` method that will help with your pagination tasks.
MIT License
112 stars 12 forks source link

fix(mssql): fix count request in MSSQL #7

Closed VincentPoencetADS closed 4 years ago

VincentPoencetADS commented 4 years ago

Add clearOrder to the cloned query during the count fixes #6

felixmosh commented 4 years ago

Hi, thank you for the PR 🙏🏼

Can you add a test for this? you can add another test file and use a mock as a driver to check what was queried.

felixmosh commented 4 years ago

I will add a test for it. Thank you anyway.

felixmosh commented 4 years ago

Published in 1.2.1