Closed s-leigh closed 2 years ago
Looks like a great PR :] Thank you for submitting it ππ½
can you rebase the master so I will be able to merge it?
Done! I remembered to run build
as well. Just have a quick glance yourself to make sure I rebased properly :)
Thank you for this PR ππΌ
There were a few things I found confusing looking at this project for my other PR, so I thought I'd suggest some very minor refactors. I kept it separate so you can just ignore this one if you like!
downloadArtifact()
orartifactApi.ts
but it seems like Axios will error if it fails, and there is already error logging if the compression fails, so it seemed both misleading and unnecessary.downloadArtifact()
that I added when putting the above logline in there before I decided against it. Left it in just for helpfulness.