felixrieseberg / npm-windows-upgrade

:rocket: Upgrade npm on Windows
MIT License
2.53k stars 149 forks source link

Make non-admin error message less specific #142

Closed cookieguru closed 5 years ago

cookieguru commented 5 years ago

The same warning is shown whether the script has been run from PowerShell or cmd. The script works fine in an administrative command prompt, so no need to send users off to PowerShell. Additionally, starting an administrative version of either environment can be performed several ways, many of which involve no clicking at all, and most users should be familiar enough with running programs as an Administrator.

felixrieseberg commented 5 years ago

I don’t know man, this looks like it’s just removing a helpful tip 😟

I think I’d be a good idea to check though if we’re in PowerShell or CMD and act accordingly!

cookieguru commented 5 years ago

@felixrieseberg I've updated the message to specify cmd or PowerShell as applicable

felixrieseberg commented 5 years ago

Thank you!