Typings & JSConfig into new Ember App Folder - Githubissues

felixrieseberg / vsc-ember-cli

:zap: Turn Visual Studio Code into an Ember Cli IDE

https://aka.ms/vsc-ember

MIT License

92 stars 15 forks source link

Typings & JSConfig into new Ember App Folder #46

Open g5codyswartz opened 7 years ago

g5codyswartz commented 7 years ago

New stuff in the correct place

When creating a new ember app the typings and JSConfig will now create in the new ember folder.

Also removes some vestigial code

ember-cli.ts isProjectSetup() & isProjectEmberCli()
- Couldn't tell if this code did anything or was needed now?

Areas of conflict & redundancy

Commented out extension.ts execute("setupProject")
- This was generating typings and jsconfig before the "new" command was ran thus creating them before a project existed.
Cannot remember if I checked for any dependencies on this.

Notes

Branched from https://github.com/ctsstc/vsc-ember-cli/tree/cross-spawn

ctsstc commented 7 years ago

Whoops posted that via the wrong account; I need to merge my accounts together some day anyways.. The diff would better show the changes if compared to the branch I branched from or after it's merged into master. I would have normally created a new separate branch based off of master, but too much wasn't working for me so I built off of the other branch I had working for me.