felixrieseberg / windows-build-tools

:package: Install C++ Build Tools for Windows using npm
MIT License
3.4k stars 237 forks source link

Does not pick up on build tools install #162

Open heddendorp opened 5 years ago

heddendorp commented 5 years ago

It seems like the installer does finish but the script does not pick up on it, relevant console output might be

PS C:\WINDOWS\system32> npm install --global windows-build-tools

> windows-build-tools@5.0.0 postinstall C:\Program Files\nodejs\node_modules\windows-build-tools
> node ./dist/index.js

Downloading python-2.7.15.amd64.msi
[>                                            ] 0.0% (0 B/s)
Downloaded python-2.7.15.amd64.msi. Saved to C:\Users\=====\.windows-build-tools\python-2.7.15.amd64.msi.
Downloading vs_BuildTools.exe
[>                                            ] 0.0% (0 B/s)
Downloaded vs_BuildTools.exe. Saved to C:\Users\=====\.windows-build-tools\vs_BuildTools.exe.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
2018-12-12T09:50:12 : Verbose : Visual Studio Installer (1.18.1089.1204 : release) ["C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\vs_installershell.exe","/finalizeInstall","install","--in","C:\\ProgramData\\Microsoft\\VisualStudio\\Packages\\_bootstrapper\\vs_setup_bootstrapper_201812120950115430.json","--norestart","--quiet","--includeRecommended","--add","Microsoft.VisualStudio.Workload.VCTools","--locale","en-US","--activityId","32fc4a65-2399-4ccf-81fc-443101420724"]
2018-12-12T09:50:12 : Verbose : Installation finalized successfully.
------------------- Python --------------------
Successfully installed Python 2.7

The following line looks like success to me

2018-12-12T09:50:12 : Verbose : Installation finalized successfully.

Maybe this should be added to the success conditions

SharakPL commented 5 years ago

The same for me. It looked like it got stuck on Successfully installed Python 2.7. After about 20 minutes of waiting it finally finished with

---------- Visual Studio Build Tools ----------
Successfully installed Visual Studio Build Tools.
------------------- Python --------------------
Successfully installed Python 2.7

Now configuring the Visual Studio Build Tools and Python...

All done!

+ windows-build-tools@5.1.0
added 145 packages from 98 contributors in 1283.19s

And that's probably another bug that it resulted with success and All done! comment because it showed bunch of errors about corrupted packages, internet problems and access denided (my connection is good and I used elevated powershell). It doesn't look successful to me:

---------- Visual Studio Build Tools ----------
2019-01-09T13:28:37 : Verbose : Resolved RemoteSettingsProviderService.GetBooleanValue(collectionPath, key, defaultValue) collectionPath: Installer\Features\, key: RecommendSel, defaultValue: false, result: false
2019-01-09T13:28:37 : Verbose : Resolved RemoteSettingsProviderService.GetBooleanValue(collectionPath, key, defaultValue) collectionPath: Installer\Features\, key: Surveys, defaultValue: false, result: false
2019-01-09T13:28:37 : Verbose : ServiceHubExperimentationClient.setSharedProperty(name, value) called,
 [name: VS.ABExp.Flights] [value: lazytoolboxinit;fwlargebuffer;refactoring;spmoretempsbtn1;asloff;keybindgoldbarext;tn-nps-15b;tn-vsmacnps-7;relnotes_exp]
2019-01-09T13:28:38 : Verbose : Resolved RemoteSettingsProviderService.GetActionsAsync(actionPath) actionPath: vs\installer\commonerroractions, result: [{"Action":{"Rules":[{"ErrorCode":"0x80072ee7","PackagesAppliesTo":[],"CommonErrorMessage":"**Error 0x80072ee7: No internet connection**\r\nThere is a problem connecting to our content delivery network servers. This might be a temporary server outage, or it could be an issue with your internet connection.\r\n\r\n**Fix**: First, select View Logs and try to go to the URL in the report. If you can, try installing Visual Studio again. If you can not access the URL in the View Logs report, or if you are on an unreliable network, please try our recommended steps to [install Visual Studio 2017 on low–bandwidth or unreliable network environments](https://docs.microsoft.com/en-us/visualstudio/install/install-vs-inconsistent-quality-network).","Resources":[{"Locale":"en-us","Message":"**Error 0x80072ee7: No internet connection**\r\nThere is a problem connecting to our content delivery network servers. This might be a temporary server outage, or it could be an issue with your internet connection.\r\n\r\n**Fix**: First, select View Logs and try to go to the URL in the report. If you can, try installing Visual Studio again. If you can not access the URL in the View Logs report, or if you are on an unreliable network, please try our recommended steps to [install Visual Studio 2017 on low–bandwidth or unreliable network environments](https://docs.microsoft.com/en-us/visualstudio/install/install-vs-inconsistent-quality-network)."}]}]},"Precedence":0,"RuleId":"1343144E-3B75-4673-AA34-82674D5F4AB0"},{"Action":{"Rules":[{"ErrorCode":"-2146233033","PackagesAppliesTo":[],"CommonErrorMessage":"**Error –2146233033: Package is corrupted**\r\nThe Visual Studio installer found a corrupted package. A package usually gets partially saved if the system was interrupted while downloading and writing the package to the disk.\r\n\r\n**Fix**: This issue usually resolves by running a repair.","Resources":[{"Locale":"en-us","Message":"**Error –2146233033: Package is corrupted**\r\nThe Visual Studio installer found a corrupted package. A package usually gets partially saved if the system was interrupted while downloading and writing the package to the disk.\r\n\r\n**Fix**: This issue usually resolves by running a repair."}]}]},"Precedence":0,"RuleId":"17674D21-417D-45EB-B671-58D521DF3D57"},{"Action":{"Rules":[{"ErrorCode":"1303","PackagesAppliesTo":[],"CommonErrorMessage":"**Error 1303: Access is denied*-