search

felixrieseberg / windows-build-tools

:package: Install C++ Build Tools for Windows using npm
MIT License
3.4k stars 237 forks source link

Add python to the path #18

Open Panthro opened 8 years ago

Panthro commented 8 years ago

It all works well, I can recompile node modules, but I hoped python would be installed and able to be used by other tools as well.

Could you consider adding python to the Path variable?

After the installation, I'm still receiving the error:

'python' is not recognized as an internal or external command,
operable program or batch file.
ali92hm commented 8 years ago

@Panthro, We didn't want to add python to the Path variable because some people have python already installed. They might want to use a specific version of python (like python 3) while our installer installs python 2.7.

You can add python to your path manually, that way we don't mess up your path variable.

Panthro commented 8 years ago

I know I can, the thing is that I'm building a tool to verify environments.

I check for all needed packages and binares, as well as other environmental settings for new developers (tired of helping every new dev in the company to setup their env).

But when I was checking for python (I use and recommend your tool), I was obviously getting an error because of the PATH thing.

I believe you can add python to the path if it wasn't there already, what do you think?

ali92hm commented 8 years ago

@felixrieseberg What do you think?

felixrieseberg commented 8 years ago

I think we could make it an option?

obsidianart commented 8 years ago

I can't find python installed and I don't know how to add it in the path, I haven't used windows for 7 years and I don't know anyone who use windows. I tried to install Python manually but node-gyp still doesn't work after so I removed everything and I'm trying again, but I'm stuck because of the Pythone path problem

Panthro commented 8 years ago

I'm theory if you install the windows build tools, the python will be available in your home folder inside a .windows-build-tools folder.

On Mon, 29 Aug 2016, 01:06 stefano solinas, notifications@github.com wrote:

I can't find python installed and I don't know how to add it in the path, I haven't used windows for 7 years and I don't know anyone who use windows. I tried to install Python manually but node-gyp still doesn't work after so I removed everything and I'm trying again, but I'm stuck because of the Pythone path problem

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/felixrieseberg/windows-build-tools/issues/18#issuecomment-243005185, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfi7cCgFgS0VXHnSXCYT7juEnqTfbpuks5qkhRdgaJpZM4JdiHT .

obsidianart commented 8 years ago

oh, I was looking in c:/python27 or /programs and thought I was crazy. Probably worth adding in the Readme as it is quite a beginner guide. Thanks a lot

Panthro commented 8 years ago

Took me some time as well when I was looking for it.

Had do dig into the actual code of this module to see where it was storing the python.

Agree that it should be stated somewhere in the readme.

On Mon, 29 Aug 2016, 02:02 stefano solinas, notifications@github.com wrote:

oh, I was looking in c:/python27 or /programs and thought I was crazy. Probably worth adding in the Readme as it is quite a beginner guide. Thanks a lot

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/felixrieseberg/windows-build-tools/issues/18#issuecomment-243008020, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfi7UV6Ga2xKTXx0o6mtRJKLEazHVFuks5qkiGggaJpZM4JdiHT .