search

felixrieseberg / windows-build-tools

:package: Install C++ Build Tools for Windows using npm
MIT License
3.4k stars 237 forks source link

Register new version #223

Open aminya opened 4 years ago

aminya commented 4 years ago

I am trying to build a project which uses Python 3, but because the latest windows-build-tools (5.2.2) does not include https://github.com/felixrieseberg/windows-build-tools/pull/205, the installation of windows-build-tools fails.

cc: @felixrieseberg @jacobq

Closes https://github.com/felixrieseberg/windows-build-tools/issues/206 Closes https://github.com/felixrieseberg/windows-build-tools/issues/220

jacobq commented 4 years ago

For now I suggest manually installing Python 3 and updating your path / settings. Unfortunately, although I can merge PRs, I cannot publish releases for this package.

aminya commented 4 years ago

@jacobq The package is currently broken. The installation does not finish. It does not matter if I install Python 3 or 2.

@felixrieseberg Could you register a new version?

jacobq commented 4 years ago

What I am trying to say is that you do not need this package to install the underlying software. It was intended as a convenience only. If you are not able to install those manually (e.g. download from python.org and microsoft.com / build tools page and execute) then you'll need to investigate the problem further as it's unrelated and far beyond the scope of windows-build-tools.

aminya commented 4 years ago

How can I skip the installation of Python altogether? It fails now in the Azure environment. Here is an example of a windows-build-tools failing installation in Azure CI. It is an endless wait for the Python installation log. https://bit.ly/31nwnQ3

DeeDeeG commented 4 years ago

If I read it correctly, at least when this happened to me, it was saying the Python install was finished and that it was waiting for the build log from the Visual Studio installer.

jacobq commented 4 years ago

How can I skip the installation of Python altogether?

You can download and install the software that you want separately without using windows-build-tools (e.g. write a short PowerShell script and use System.Net.WebClient) See https://github.com/nodejs/node-gyp#option-2

You can also try using v4 (npm install --global --production windows-build-tools@4.0.0), with which other people have reported success

aminya commented 4 years ago

Registration did not help with the issue. I tested this with the version registered on my account.

The issue is in Tailer. It never finds the log files for the MS Build tools installation.
https://github.com/felixrieseberg/windows-build-tools/blob/0ef17446b88f188a116af93c64b69ee4efc06804/src/install/tailer.ts#L23-L32

https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=643&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5 image

jacobq commented 4 years ago

Registration did not help with the issue. I tested this with the version registered on my account.

Not sure what you mean by "registration". Would you care to elaborate on this?

The issue is in Tailer. It never finds the log files for the MS Build tools installation.

Seems like a duplicate of #152, #172, #174, #208.... Is there something different in this case that I'm missing? If not, let's close this issue in favor of the pre-existing ones and the new PRs you started (#224 and #225). Thanks for diving into this. Please let me know if you would like me to test, review, etc. If you can resolve this problem I will take some time to seek @felixrieseberg and see if I can get access to publish a new version to npm.

DeeDeeG commented 4 years ago

Not sure what you mean by "registration". Would you care to elaborate on this?

I believe this is referring to using this module (the forked/updated version) as a published package on the npm package registry, as opposed to installing it from a git URL.

https://www.npmjs.com/package/@aminya/windows-build-tools

For context: We collaborate on another project, and oddly enough one of our dependencies would not install as a git dependency, but installing it from the package registry worked just fine.

aminya commented 4 years ago

For context: We collaborate on another project, and oddly enough one of our dependencies would not install as a git dependency, but installing it from the package registry worked just fine.

For windows-build-tools, it is because of Typescript. You need to build. Git installation does not build