search

felixrieseberg / windows-build-tools

:package: Install C++ Build Tools for Windows using npm
MIT License
3.4k stars 237 forks source link

wait for the installation of windows-build-tools #225

Open aminya opened 4 years ago

aminya commented 4 years ago

This PR tries to fix the problem of endless waits.

Changes

1) Add --wait to vs build tools Based on the documentation, with this option:

the process will wait until the install is completed before returning an exit code. This is useful when automating installations where one needs to wait for the install to finish to handle the return code from that install.

2)

Fixes https://github.com/felixrieseberg/windows-build-tools/issues/172 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/216 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/208 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/147 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/215 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/200 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/105 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/145 Fixes https://github.com/felixrieseberg/windows-build-tools/issues/97

jacobq commented 4 years ago

Have you tried this? (Does it work?)

aminya commented 4 years ago

It doesn't fully solve the issue yet. That's why it is still a draft.

quinton-ashley commented 4 years ago

Please fix this

aminya commented 4 years ago

To fix this we need to find a better way to understand if the installation is done. Currently, the script waits for the installation log, which does not seem like the best way to determine the end of the installation.

jacobq commented 3 years ago

Just checking in as this still appears to be in WIP. Any plans to continue development? Are there tasks for which you'd like to get help from others?