search

felixrieseberg / windows-build-tools

:package: Install C++ Build Tools for Windows using npm
MIT License
3.4k stars 237 forks source link

Python 2.7 installation ends up in endless loop #228

Open ain opened 3 years ago

ain commented 3 years ago

Steps to reproduce

  1. Run installation on Microsoft Windows Server 2019 (e.g. on GitHub Actions)

    $ npm install --global --production windows-build-tools

What happens

------------------- Python --------------------
5485
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5486
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5487
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5488
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5489
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5490
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5491
------------------- Python --------------------
5492
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5493
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5494
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5495
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5496
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5497
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5498
------------------- Python --------------------
5499
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5500
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5501
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5502
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5503
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5504
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5505
------------------- Python --------------------
5506
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5507
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5508
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5509
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5510
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5511
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5512
------------------- Python --------------------
5513
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5514
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5515
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5516
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5517
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5518
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5519
------------------- Python --------------------
5520
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5521
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5522
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5523
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5524
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5525
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]
5526
------------------- Python --------------------
5527
Successfully installed Python 2.7---------- Visual Studio Build Tools ----------
5528
2020-11-11T22:13:25 : Verbose : [InstalledProductsProviderImpl]: Stream was closed
5529
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Rpc connection was closed.
5530
2020-11-11T22:13:25 : Verbose : [InstallerImpl]: Stream was closed
5531
2020-11-11T22:13:25 : Verbose : Completed notifying all clients that the update is starting
5532
2020-11-11T22:13:25 : Verbose : Updating installer [bootstrapperArguments: -- /finalizeInstall install --in C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_202011112212481801.json --norestart --quiet --includeRecommended --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId df7dff38-98bb-4bf5-8fdc-6903cb43bfd7]

Before cancelling the workflow, it ran in the loop for 11 min.

What should happen

Installation should succeed.

papb commented 3 years ago

I agree this is weird, but do you really need to install this package inside GitHub Actions? I would guess it already worked out of the box.

ain commented 3 years ago

@papb would be glad to avoid, but it seems node-sass installation failure bound to node-gyp is the bottleneck here:

npm ERR! gyp ERR! System Windows_NT 10.0.17763
647
npm ERR! gyp ERR! command "C:\\hostedtoolcache\\windows\\node\\15.2.0\\x64\\node.exe" "D:\\a\\smartbanner.js\\smartbanner.js\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
648
npm ERR! gyp ERR! cwd D:\a\smartbanner.js\smartbanner.js\node_modules\node-sass
649
npm ERR! gyp ERR! node -v v15.2.0
650
npm ERR! gyp ERR! node-gyp -v v3.8.0
651
npm ERR! gyp ERR! This is a bug in `node-gyp`.
652
npm ERR! gyp ERR! Try to update node-gyp and file an Issue if it does not help:
653
npm ERR! gyp ERR!     <https://github.com/nodejs/node-gyp/issues>
654
npm ERR! Build failed with error code: 7
ain commented 3 years ago

A note worth making: running without npm install --global --production windows-build-tools and directly against npm install succeeds when on Node.js v14.x, but node-gyp install fails on Node.js v15.x.

hovancik commented 3 years ago

Having same issues, install is in endless loop

sebthom commented 3 years ago

Same issue when using Windows Server 2016

sebthom commented 3 years ago

I also tried to pre-install Python 2.7. Now there is an endless loop continuously printing

------------------- Python --------------------
Python 2.7.18 is already installed, not installing again.---------- Visual Studio Build Tools ----------
2021-03-18T19:28:15 : Verbose : Calling SetupEngine.Installer.EvaluateInstallParameters. [channelId: VisualStudio.15.Release, productId: Microsoft.VisualStudio.Product.BuildTools, installationPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools', languages: 'en-US' selectedPackageReferences.length: 13]
2021-03-18T19:28:15 : Verbose : SetupEngine.Installer.EvaluateInstallParameters succeeded. [channelId: VisualStudio.15.Release, productId: Microsoft.VisualStudio.Product.BuildTools, installationPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools', languages: 'en-US' selectedPackageReferences.length: 13]
2021-03-18T19:28:15 : Verbose : Calling SetupEngine.Installer.EvaluateInstallParameters. [channelId: VisualStudio.15.Release, productId: Microsoft.VisualStudio.Product.BuildTools, installationPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools', languages: 'en-US' selectedPackageReferences.length: 13]
2021-03-18T19:28:15 : Verbose : SetupEngine.Installer.EvaluateInstallParameters succeeded. [channelId: VisualStudio.15.Release, productId: Microsoft.VisualStudio.Product.BuildTools, installationPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools', languages: 'en-US' selectedPackageReferences.length: 13]
2021-03-18T19:28:15 : Verbose : Calling SetupEngine.Installer.InstallProduct. [channelId: VisualStudio.15.Release, productId: Microsoft.VisualStudio.Product.BuildTools, installationPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools']