search

felixrupp / user_cas

This app provides CAS authentication support for ownCloud and Nextcloud, using the phpCAS library of jasig/apereo.
Other
21 stars 24 forks source link

user_cas breaks Nextcloud when theming is used #38

Closed centredecalcul closed 5 years ago

centredecalcul commented 6 years ago

To Reproduce:

  1. Fresh install with user_cas and user_ldap working good
  2. Modify the site name with Theming app
  3. Try to log on
  4. Only a blank page is shown
  5. Disable user_cas for Nextcloud to work again

Software:

Log:

{"reqId":"W-P9ciu753Xmiw8mvOPx2AAAAAA","level":3,"time":"2018-11-20T12:26:26+00:00","remoteAddr":"1.2.3.4","user":"abcdLogin","app":"PHP","method":"GET","url":"\/","message":"Declaration of OCA\UserCAS\User\Backend::checkPassword($uid, $password) must be compatible with OCP\User\Backend\ICheckPasswordBackend::checkPassword(string $loginName, string $password) at \/var\/www\/owncloud_dev\/nextcloud-14.0.3-20181120\/apps\/user_cas\/lib\/User\/Backend.php#45","userAgent":"Mozilla\/5.0 (X11; Linux x86_64; rv:52.0) Gecko\/20100101 Firefox\/52.0","version":"14.0.3.0"}

reswild commented 5 years ago

It's odd that this happens only when using the Theming app. In any case, this patch should take care of that error: https://github.com/reswild/user_cas/commit/5130f5bd1a5718f12c90e61cc03ec410ad65f1b7

centredecalcul commented 5 years ago

It works, thank you !