search

felixrupp / user_cas

This app provides CAS authentication support for ownCloud and Nextcloud, using the phpCAS library of jasig/apereo.
Other
21 stars 24 forks source link

FixBugLogoutNextcloudFromCas =) #81

Closed pingou2712 closed 4 years ago

pingou2712 commented 4 years ago

Fix bug : Difference between: -> logout CAS session if logout Nextcloud session And: -> logout Nextcloud session if logout CAS session

For language i update l10n/fr ( l10n/fr.js , l10n/fr.json) , i don't know what i must do...

I have an another perso patch for group naming because your code don't do what i want... tell me if you are interested ;) Bye

alexisberindei commented 4 years ago

It's working well ! Need some more tests but for now well done 👍

pingou2712 commented 4 years ago

thank you ;) I'm happy to help!

felixrupp commented 4 years ago

@pingou2712 I implemented your callback function into the code, without the other unnecessary changes. Please see Release 1.8.3.

Thank you for your input!

pingou2712 commented 4 years ago

You continue to confuse two very different things: -> logout of the CAS session if there is logout of the Owncloud session (some people want this option) -> logout of the Owncloud session if there is logout of the CAS session (few people want this option) It's two very different options. The code that you get out of my patch was not unnecessary, please think carefully about this question. Please, tell me if you don't change your mind because this would force me to make another personal patch. thank you for all =)

felixrupp commented 4 years ago

Hi @pingou2712

You‘re right. My current approach was, as always, based on what is given (configured) by the CAS server. So, if you don‘t want SingleSignout, just disable it in your CAS server instance. If you disable the CAS logout in user_cas in general (and only terminate the ownCloud session), a SingleSignout makes no sense in my opinion.

But if it helps you, I will add another checkbox option to enable/disable both features seperately tomorrow.

Regards, Felix

pingou2712 commented 4 years ago

@alexisberindei

I add made some changement: With the first version : all the session are destroy (so if you have smartphone or client, it deconnect too...), or juste an other pc with an other CAS Ticket, all are destroy With the second version (https://github.com/felixrupp/user_cas/pull/85), just the session initiate by CAS are destroy... it's more normal... =) if you want to test...

@++

alexisberindei commented 4 years ago

Indeed it's not what we want ahah. I'll try again asap.

Thank you @pingou2712 !

pingou2712 commented 4 years ago

@alexisberindei Ok Done. Last version https://github.com/felixrupp/user_cas/pull/87 :P The previous version don't remove connection of smartphone... So not good... I made a job for clean up.